Fix buffer overflow in Life Safety Point and Zone Read_Property for accepted-modes property - #1354
Merged
Merged
Conversation
…ccepted-modes property
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent buffer overflows when encoding the Accepted-Modes property in the Life Safety Point and Zone objects’ Read_Property handlers by switching to a size-aware enumerated encoder.
Changes:
- Use
bacnet_enumerated_application_encode()to encode each accepted mode with APDU bounds. - Track
apdu_sizeinLife_Safety_Point_Read_Property()to compute remaining space during encoding.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/bacnet/basic/object/lsz.c |
Updates Accepted-Modes encoding in Life_Safety_Zone_Read_Property() to use a bounded enumerated encoder. |
src/bacnet/basic/object/lsp.c |
Adds apdu_size tracking and updates Accepted-Modes encoding in Life_Safety_Point_Read_Property() to use a bounded enumerated encoder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.