Fix buffer overflow issues in Loop object internal Read_Property function - #1355
Merged
skarg merged 2 commits intoMay 19, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a buffer overflow risk in the Loop object’s internal referenced-property read path by replacing a small fixed-size APDU buffer with a MAX_APDU-sized buffer when invoking the internal ReadProperty callback.
Changes:
- Added a MAX_APDU-sized buffer for internal ReadProperty callback usage.
- Updated
Loop_Read_Variable_Reference_Update()to use the new buffer and removed the previous 32-byte local buffer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /* handling for manipulated and reference properties */ | ||
| static write_property_function Write_Property_Internal_Callback; | ||
| static read_property_function Read_Property_Internal_Callback; | ||
| static uint8_t Read_Property_Buffer[MAX_APDU]; |
skarg
deleted the
bugfix/loop-object-read-property-internal-buffer-overflow
branch
May 19, 2026 14:10
skarg
added a commit
that referenced
this pull request
May 26, 2026
skarg
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.