Feature: Add test-only shim for bsc_node_parse_urls() to support unit testing - #1369
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a test-only entry point to exercise the internal BACnet/SC node URL parsing logic from unit tests, improving coverage of edge cases around URI length and count limits.
Changes:
- Introduces a
CONFIG_ZTEST-gated shim (bsc_node_test_parse_urls()) that exposes the internal staticbsc_node_parse_urls()to tests. - Adds a new ztest suite (
node_test_8) with targeted cases covering empty payloads, boundary lengths, truncation by URL count, and multi-URL parsing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/bacnet/datalink/bsc-node/src/main.c | Adds a new unit test suite validating URL parsing behavior across boundary conditions. |
| src/bacnet/datalink/bsc/bsc-node.c | Adds a CONFIG_ZTEST-only shim function to expose the internal URL parser to unit tests. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
skarg
added a commit
that referenced
this pull request
Jun 25, 2026
* Fix buffer overflows in bsc_node_parse_urls() Three bugs in the BACnet/SC Address Resolution ACK URL parser: 1. NUL terminator used absolute string position 'i' as array index instead of relative position 'i - start', writing past the 129-byte utf8_urls buffer for URLs starting past position 128. 2. No bounds check on URL count index 'j', allowing writes past the 10-element utf8_urls array when parsing 11+ URLs, corrupting urls_num, fresh_timer, and adjacent structures. 3. Length check compared absolute position 'i' against the max URI size instead of the actual URL length '(i - start)', incorrectly rejecting valid short URLs at high string offsets. Fixes all three by using relative lengths and adding array bounds checks before every write. Add test-only shim for bsc_node_parse_urls() to support unit testing (#1369)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.