Bugfix/remote global buffer overflow in apps router - #1392
Merged
skarg merged 11 commits intoJun 19, 2026
Conversation
…consistent debug output
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent a potential transmit-buffer overflow when routing remote/global APDUs in the router demo apps, while also consolidating router logging onto the stack’s debug_log_fprintf() infrastructure (including parsing log severity from an ASCII value).
Changes:
- Add
debug_log_severity_ascii_set()to set debug severity from a numeric string (e.g., env var). - Refactor
apps/router-mstpandapps/router-ipv6routing/logging, introducingrouted_apdu_encode()with an explicit oversized-PDU drop check. - Harden protocol-version access (avoid reading
pdu[0]whenpdu_len == 0) and gate IPv6 routermain()behind#ifndef FUZZING.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| src/bacnet/basic/sys/debug.h | Exposes new API to set log severity from an ASCII string. |
| src/bacnet/basic/sys/debug.c | Implements ASCII-to-severity parsing via bacnet_strtol(). |
| apps/router-mstp/main.c | Switches to debug_log_fprintf(), adds routed APDU encode+size check, updates debug env handling. |
| apps/router-ipv6/main.c | Same routing/logging refactor as MS/TP router + fuzzing guard; adds routed APDU encode+size check. |
…l-buffer-overflow-in-apps-router
…or the BACNET_ROUTER_DEBUG environment variable.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
skarg
added a commit
that referenced
this pull request
Jun 29, 2026
* Refactor apps/router-mstp and apps/router-ipv6 routing, introducing routed_npdu_apdu_encode() with an explicit oversized-PDU drop check. * Harden protocol-version access (avoid reading pdu[0] when pdu_len == 0)
skarg
added a commit
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.