fix: Life Safety Zone member handling for write property - #1410
Merged
skarg merged 2 commits intoJun 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Life_Safety_Zone handling for PROP_ZONE_MEMBERS WriteProperty so that malformed/misaligned payloads don’t partially update the object’s Zone Members list, and adds regression tests to lock in the expected decode/commit behavior.
Changes:
- Update
Life_Safety_Zone_Members_Write()to fully validate/stage decoded Zone Members before committing them to the object. - Fix
Life_Safety_Zone_Members_Add()to correctly interpretKeylist_Data_Add()return values and free allocations on add failure. - Add Zephyr ztest regression coverage for Zone Members WriteProperty decode edge cases (zero-length decode, truncated data, malformed tail, multi-element).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/bacnet/basic/object/lsz/src/main.c | Adds helper routines and regression ztests for Zone Members WriteProperty decode/commit behavior. |
| src/bacnet/basic/object/lsz.c | Makes Zone Members writes transactional (stage then commit) and fixes add failure handling to avoid leaks/false-success. |
skarg
deleted the
bugfix/denial-of-service-in-life-safety-zone-write-property-zone-members
branch
June 27, 2026 19:37
skarg
added a commit
that referenced
this pull request
Jul 2, 2026
skarg
added a commit
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.