fix: add read-only check for file size setting and zero new memory in RAMFS - #1411
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens File Object behavior by enforcing Read_Only semantics when attempting to set File_Size, and improves RAMFS safety by zero-initializing newly allocated bytes when expanding an in-memory file buffer.
Changes:
- Zero-fill newly allocated memory when RAMFS file size grows to avoid exposing uninitialized heap contents via subsequent reads.
- Block
File_Sizewrites when the BACnet File object is markedRead_Only, returning write-access-denied to the WriteProperty handler.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bacnet/basic/sys/bramfs.c | Zero-initializes newly added RAMFS buffer bytes after realloc() when a file is expanded. |
| src/bacnet/basic/object/bacfile.c | Adds a Read_Only guard to bacfile_file_size_set() so WriteProperty properly denies PROP_FILE_SIZE updates on read-only objects. |
skarg
added a commit
that referenced
this pull request
Jul 2, 2026
skarg
added a commit
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.