fix: address out-of-bounds read in lighting_command_decode and add bounds checking tests - #1412
Merged
skarg merged 4 commits intoJun 28, 2026
Merged
Conversation
…unds checking tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens BACnet Lighting Command APDU decoding by fixing a bounds/remaining-length bug in lighting_command_decode() and adds a Zephyr ztest regression test intended to exercise truncation scenarios.
Changes:
- Update nested decode calls in
lighting_command_decode()to pass the remaining buffer length (apdu_size - apdu_len) to prevent out-of-bounds reads. - Add a new ztest that iteratively truncates encoded lighting commands and decodes them to validate bounds behavior.
- Register the new test in the existing lighting ztest suite (legacy API path).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/bacnet/lighting.c |
Fix remaining-length propagation in lighting_command_decode() for operation-dependent nested decodes. |
test/bacnet/lighting/src/main.c |
Add truncation/bounds-checking test coverage for lighting_command_decode() and wire it into the suite. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…e decoder does not exceed provided buffer
skarg
added a commit
that referenced
this pull request
Jul 2, 2026
…unds checking tests (#1412) * fix: address out-of-bounds read in lighting_command_decode and add bounds checking tests * fix: FADE_TO and RAMP_TO required levels in lighting_command_decode
skarg
added a commit
that referenced
this pull request
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.