Skip to content

Fixes #288: Added Dropdown for BeadExplorer and BeadExplorer/Network trends for smaller screens#328

Draft
parthdude07 wants to merge 30 commits into
braidpool:devfrom
parthdude07:added_dropdown
Draft

Fixes #288: Added Dropdown for BeadExplorer and BeadExplorer/Network trends for smaller screens#328
parthdude07 wants to merge 30 commits into
braidpool:devfrom
parthdude07:added_dropdown

Conversation

@parthdude07

@parthdude07 parthdude07 commented Dec 27, 2025

Copy link
Copy Markdown

📱 Description

This PR addresses UI responsiveness issues in the dashboard header to ensure smooth rendering across mobile and desktop devices.
fixes #288

🛠 Key Changes

  • Mobile Navigation: Converted the "Beads Explorer", "Network Trends", "Rewards" and "Pool Dominance" tabs into a Dropdown Menu for mobile screens (< sm) while retaining the tab layout for desktop.
    • In Network Trends : Converted the "Hashrate", "Latency", "Transactions" and "Difficulty" tabs into a Dropdown Menu for mobile screens (< sm) while retaining the tab layout for desktop.

Copilot AI review requested due to automatic review settings December 27, 2025 09:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds responsive dropdown navigation for the BeadExplorer and Network Trends sections to improve usability on smaller screens (issue #288). The changes introduce mobile-friendly select dropdowns that replace the horizontal tab navigation on small screens.

  • Adds dropdown selectors that appear on mobile/small screens (hidden on medium+ screens)
  • Hides desktop tab navigation on small screens while showing it on medium+ screens
  • Implements state management for active tab selection at the Dashboard level

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
dashboard/src/components/Dashboard/Dashboard.tsx Adds activeTab state management and dropdown in Card headerExtra for mobile BeadExplorer navigation
dashboard/src/components/BeadsTab/Trends/TrendsTab.tsx Adds mobile dropdown for Network Trends sub-tabs (hashrate, latency, etc.) with responsive visibility
dashboard/src/components/BeadsTab/MinedSharesExplorer.tsx Converts to controlled component accepting activeTab props, hides DashboardHeader on mobile
dashboard/src/components/BeadsTab/DashboardHeader.tsx Splits into mobile dropdown and desktop tab views with responsive visibility classes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dashboard/src/components/Dashboard/Dashboard.tsx Outdated
Comment thread dashboard/src/components/BeadsTab/Trends/TrendsTab.tsx Outdated
Comment thread dashboard/src/components/BeadsTab/MinedSharesExplorer.tsx Outdated
Comment thread dashboard/src/components/BeadsTab/DashboardHeader.tsx Outdated
Comment thread dashboard/src/components/BeadsTab/Trends/TrendsTab.tsx

@parthdude07 parthdude07 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented some suggestions from Copilot

@priyashuu priyashuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits must be signed to be merged. Please also include a PR description for future reference.

@parthdude07

Copy link
Copy Markdown
Author

@priyashuu i had made the changes

priyashuu
priyashuu previously approved these changes Jan 1, 2026

@priyashuu priyashuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priyashuu priyashuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to sign your older commits. Unsigned commits cannot be merged.

@parthdude07

Copy link
Copy Markdown
Author

Hi @priyashuu , I’ve now signed the older commits as requested.
Apologies for the delay — I was traveling and couldn’t address it earlier.
Thanks for your patience.

@parthdude07

Copy link
Copy Markdown
Author

@mcelrath @priyashuu
waiting for workflow approval

@priyashuu

Copy link
Copy Markdown
Contributor

@mcelrath @priyashuu waiting for workflow approval

Please address and resolve the issues with the failed CI tests.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dashboard/src/components/BeadsTab/MinedSharesExplorer.tsx
Comment thread dashboard/src/components/Dashboard/Dashboard.tsx Outdated
<nav className="mb-px flex flex-wrap gap-x-6" aria-label="Tabs">
{/* --- Mobile View: Dropdown --- */}
{/* Using ! to force responsive behavior against external overrides */}
<div className="block md:!hidden py-4">

Copilot AI Jan 15, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The !important modifier on responsive classes (md:!hidden, md:!block) indicates underlying specificity issues. Consider refactoring the conflicting global styles instead of using !important, which can make future styling changes more difficult and error-prone.

Copilot uses AI. Check for mistakes.

@priyashuu priyashuu Jan 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can avoid using the !important modifier by leveraging Tailwind’s responsive utilities. For example, instead of block md:!hidden, you could use:sm:block max-md:hidden lg:hidden

Comment thread dashboard/src/components/BeadsTab/Trends/TrendsTab.tsx Outdated
Comment thread dashboard/src/components/BeadsTab/MinedSharesExplorer.tsx Outdated
Comment thread dashboard/src/components/BeadsTab/Trends/TrendsTab.tsx Outdated
Comment thread dashboard/src/components/Dashboard/Dashboard.tsx Outdated
@priyashuu

Copy link
Copy Markdown
Contributor

Please address the copilot suggestions.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread dashboard/src/components/BeadsTab/DashboardHeader.tsx Outdated
@parthdude07

parthdude07 commented Jan 16, 2026

Copy link
Copy Markdown
Author

@priyashuu can you once review this
it will be great if this PR can be merge
today

@priyashuu

Copy link
Copy Markdown
Contributor

@priyashuu can you once review this it will be great if this PR can be merge today

sure

@priyashuu priyashuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed the UI. On md screens, there’s a lot of unused space on the right, making the layout feel unbalanced, this could be utilized better.

Also, the Network subtabs dropdown isn’t needed on md+ screens. It would be better to show the dropdown only on small devices

Image

{/* Navigation Area */}
<div className="border-b border-gray-800">
{/* Mobile View: Dropdown (Hidden on small screens and up) */}
<div className="sm:hidden mb-4 px-2">

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@priyashuu the dropdown for network subtab is show for smaller screens only below sm

@priyashuu

Copy link
Copy Markdown
Contributor

As mentioned, I’ve reviewed the UI on md screens. Based on basic UI/UX principles, the current layout leaves a lot of unused space on the right and still uses a dropdown for the Network subtabs. Since sufficient space is available on md screens
image

@parthdude07

Copy link
Copy Markdown
Author

I’ve reviewed the UI. On md screens, there’s a lot of unused space on the right, making the layout feel unbalanced, this could be utilized better.

Also, the Network subtabs dropdown isn’t needed on md+ screens. It would be better to show the dropdown only on small devices

Image

thanks for review @priyashuu . for i had changed the break points to sm in last commits.
yeah but still there is lot of unused space on the right . should i increase the length of the dropdown inorder to occupy some more space and layout feel balanced??

@priyashuu

Copy link
Copy Markdown
Contributor

I’ve reviewed the UI. On md screens, there’s a lot of unused space on the right, making the layout feel unbalanced, this could be utilized better.
Also, the Network subtabs dropdown isn’t needed on md+ screens. It would be better to show the dropdown only on small devices
Image

thanks for review @priyashuu . for i had changed the break points to sm in last commits. yeah but still there is lot of unused space on the right . should i increase the length of the dropdown inorder to occupy some more space and layout feel balanced??

You can try that, but my suggestion would be to remove the dropdown on md screens altogether. The dropdown should ideally only trigger on small screens and below.

@parthdude07

parthdude07 commented Jan 29, 2026

Copy link
Copy Markdown
Author

@priyashuu sorry but i had used sm 640 px as break point which means dropdown shows for smaller screens only . do you want me to make even smaller the breakpoint??

@parthdude07

Copy link
Copy Markdown
Author

@priyashuu had you reviewed the code??

@parthdude07 parthdude07 requested a review from priyashuu February 6, 2026 09:55
@parthdude07

Copy link
Copy Markdown
Author

@priyashuu i had made the requested changes and now the UI looks more consistent than before no unused space btw . can you please review the code changes. thanks

@priyashuu priyashuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue still persists after the latest changes. Please re-test locally and push an updated fix.
Image

@parthdude07

Copy link
Copy Markdown
Author
Screencast.from.2026-02-07.14-57-53.webm

@priyashuu Can you check this changes please and suggest any changes if required . thanks

@priyashuu

Copy link
Copy Markdown
Contributor

hey @parthdude07 , is there any update on this pr?

@parthdude07

Copy link
Copy Markdown
Author

@priyashuu my midsems are ongoing. Will raise PR soon.

@priyashuu priyashuu marked this pull request as draft February 22, 2026 06:58
@priyashuu

Copy link
Copy Markdown
Contributor

Hey @parthdude07, do you have any updates on this PR?

@parthdude07

Copy link
Copy Markdown
Author

Hey @parthdude07, do you have any updates on this PR?

@priyashuu will raise the PR by EOD.

@parthdude07 parthdude07 marked this pull request as ready for review March 16, 2026 05:00
@parthdude07

Copy link
Copy Markdown
Author

Screencast from 2026-03-16 10-08-58.webm
@priyashuu i have added the collapsible side for for beadexplorer tab

@mcelrath mcelrath marked this pull request as draft April 10, 2026 16:50

@priyashuu priyashuu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions for the UI:

  • In the future, we are removing the “BEADS EXPLORER” section, so you need to change the tab name from “Beads Explorer” to “Braid Visualization”. You can check the constants.ts file under the tabs constants.
Image
  • Also, you added a new sidebar, but we already have an existing sidebar for the navbar. Can you match your design with the existing one instead?

@priyashuu

Copy link
Copy Markdown
Contributor

Here are some suggestions for the UI:

  • In the future, we are removing the “BEADS EXPLORER” tab, so you need to change the tab name from “Beads Explorer” to “Braid Visualization”. You can check the constants.ts file under the tabs constants.
Image * Also, you added a new sidebar, but we already have an existing sidebar for the navbar. Can you match your design with the existing one instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants