Enable autoFields in order to resolve lazy loading translated entities.#13411
Merged
Conversation
ADmad
approved these changes
Jul 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #13411 +/- ##
============================================
+ Coverage 90.94% 90.94% +<.01%
Complexity 13997 13997
============================================
Files 523 523
Lines 36318 36319 +1
============================================
+ Hits 33029 33030 +1
Misses 3289 3289
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #13411 +/- ##
============================================
+ Coverage 90.94% 90.94% +<.01%
Complexity 13997 13997
============================================
Files 523 523
Lines 36318 36319 +1
============================================
+ Hits 33029 33030 +1
Misses 3289 3289
Continue to review full report at Codecov.
|
markstory
reviewed
Jul 12, 2019
|
|
||
| $entity = $table->get(1); | ||
| $result = $table->loadInto($entity, ['Authors']); | ||
| $this->assertSame($entity, $result); |
Member
There was a problem hiding this comment.
Should there be assertions that the Authors + translation were loaded?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #13181, the fix also resolves a failing test case #13182