Skip to content

[ISSUE #521]Remove unused import#522

Merged
pierDipi merged 2 commits into
cloudevents:mainfrom
mxsm:mxsm-521
Feb 20, 2023
Merged

[ISSUE #521]Remove unused import#522
pierDipi merged 2 commits into
cloudevents:mainfrom
mxsm:mxsm-521

Conversation

@mxsm

@mxsm mxsm commented Feb 18, 2023

Copy link
Copy Markdown
Contributor

close #521

  • Remove unused import

@mxsm mxsm force-pushed the mxsm-521 branch 2 times, most recently from 3506ada to 10b3bbd Compare February 18, 2023 12:59

@pierDipi pierDipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

import io.quarkus.test.junit.QuarkusTest;
import org.junit.jupiter.api.Test;


Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for this empty line? Can we remove it?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pierDipi I will remove it and resbumit this pr later.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

You can alternatively accept this suggestion

mxsm added 2 commits February 20, 2023 20:51
Signed-off-by: mxsm <ljbmxsm@gmail.com>
Signed-off-by: mxsm <ljbmxsm@gmail.com>
@mxsm

mxsm commented Feb 20, 2023

Copy link
Copy Markdown
Contributor Author

@pierDipi PTAL~ thanks

@pierDipi pierDipi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@pierDipi pierDipi merged commit d64aff7 into cloudevents:main Feb 20, 2023
@mxsm mxsm deleted the mxsm-521 branch February 21, 2023 02:47
skepticoitusInteruptus pushed a commit to skepticoitusInteruptus/sdk-java that referenced this pull request Mar 23, 2023
Signed-off-by: mxsm <ljbmxsm@gmail.com>
Signed-off-by: Randi Sheaffer-Klass <97033958+skepticoitusInteruptus@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused import

2 participants