fix(codemode): extend default dynamic worker timeout#1806
Merged
threepointone merged 1 commit intoJun 24, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 6df7796 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
threepointone
approved these changes
Jun 24, 2026
Merged
mattzcarey
pushed a commit
that referenced
this pull request
Jun 24, 2026
The request() callback runs while the sandbox is suspended on its codemode.request() RPC, so the DynamicWorkerExecutor timeout bounds the human-in-the-loop elicitation wait. The default executor timeout (60s, #1806) already matches the elicitation timeout; document that lowering it below the elicitation timeout aborts the call before the user can respond.
mattzcarey
pushed a commit
that referenced
this pull request
Jun 25, 2026
The request() callback runs while the sandbox is suspended on its codemode.request() RPC, so the DynamicWorkerExecutor timeout bounds the human-in-the-loop elicitation wait. The default executor timeout (60s, #1806) already matches the elicitation timeout; document that lowering it below the elicitation timeout aborts the call before the user can respond.
mattzcarey
added a commit
that referenced
this pull request
Jun 25, 2026
* fix(codemode): preserve MCP request context * test(mcp): cover codemode request context over real McpAgent transport Adds a TestCodemodeMcpAgent that registers openApiMcpServer and elicits via McpAgent.elicitInput with the forwarded relatedRequestId. The test drives a real Streamable HTTP POST with no standalone GET stream through the Worker Loader executor RPC boundary, asserts the elicitation rides the originating POST and the tool result follows it, and checks the keepAlive lease is held during the nested wait and released afterward. * docs(codemode): note executor timeout must cover elicitation wait The request() callback runs while the sandbox is suspended on its codemode.request() RPC, so the DynamicWorkerExecutor timeout bounds the human-in-the-loop elicitation wait. The default executor timeout (60s, #1806) already matches the elicitation timeout; document that lowering it below the elicitation timeout aborts the call before the user can respond.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note: no example changes are included in this PR; the deployment smoke check used a separate throwaway Worker, which has since been deleted.