fix(tests): bind test server to loopback so Firefox/WebKit can connect#200
Open
SamJB123 wants to merge 1 commit into
Open
fix(tests): bind test server to loopback so Firefox/WebKit can connect#200SamJB123 wants to merge 1 commit into
SamJB123 wants to merge 1 commit into
Conversation
The global test server called `httpServer.listen(0)` with no host, so on dual-stack hosts Node binds the IPv6 wildcard `::`. That address is then provided to clients verbatim as `testServerHost`, so tests connect to `http://[::]:PORT` / `ws://[::]:PORT`. Chromium tolerates connecting to the wildcard `[::]`, but Firefox and WebKit reject it, causing the `browsers-without-using` project to fail deterministically on those engines: - HTTP requests > can perform a batch HTTP request (NetworkError / Load failed) - WebSockets > can open a WebSocket connection (WebSocket connection failed) Bind explicitly to `127.0.0.1` so every engine gets a concrete loopback target. Passing a host makes `listen()` take the async DNS-resolution path, so we await the "listening" event before reading `address()` (with no host, binding was synchronous). Verified on macOS: Firefox and WebKit go from failing those two tests to passing; node and workerd are unaffected. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global test server called
httpServer.listen(0)with no host, so on dual-stack hosts Node binds the IPv6 wildcard::. That address is then provided to clients verbatim astestServerHost, so tests connect tohttp://[::]:PORT/ws://[::]:PORT.Chromium tolerates connecting to the wildcard
[::], but Firefox and WebKit reject it, causing thebrowsers-without-usingproject to fail deterministically on those engines:Bind explicitly to
127.0.0.1so every engine gets a concrete loopback target. Passing a host makeslisten()take the async DNS-resolution path, so we await the "listening" event before readingaddress()(with no host, binding was synchronous).Verified on macOS: Firefox and WebKit go from failing those two tests to passing; node and workerd are unaffected.