Skip to content

Improve client generation steps#31423

Open
harshil1712 wants to merge 5 commits into
productionfrom
oauth-docs
Open

Improve client generation steps#31423
harshil1712 wants to merge 5 commits into
productionfrom
oauth-docs

Conversation

@harshil1712

Copy link
Copy Markdown
Contributor

Summary

Improves the OAuth client generation steps.

Documentation checklist

@harshil1712 harshil1712 requested a review from a team as a code owner June 12, 2026 14:30
@cloudflare-docs-bot

cloudflare-docs-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review

⏸️ Automatic reviews for this PR are paused.

This PR has already received 2 automatic reviews. To run another review, a codeowner can comment /review or /full-review.

Tip: Keep PRs in draft mode until they are ready for review — the bot skips draft PRs automatically.


✅ No style-guide issues found in commit 5dd6aff.

Commands

Only codeowners can run commands. Post a comment with the command to trigger it.

Command Description
/review Runs a review now. Incremental if a prior review exists, full if not.
/full-review Re-reviews the entire PR diff from scratch, ignoring incremental history. Useful after a rebase, when you want a fresh review, or if the bot gets out of sync and reports issues that no longer exist.

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:

Pattern Owners
/.github/CODEOWNERS @cloudflare/product-owners, @cloudflare/content-engineering, @kodster28
/src/content/docs/fundamentals/oauth/ @AdamBouhmad, @dcpena, @cloudflare/product-owners

@ask-bonk ask-bonk Bot changed the title Improve client genration steps Improve client generation steps Jun 12, 2026
@ask-bonk ask-bonk Bot added documentation Documentation edits content:edit Request for content edits labels Jun 12, 2026

@ask-bonk ask-bonk Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the typo in the PR title and added labels. One style issue to address:

Comment thread src/content/docs/fundamentals/oauth/create-an-oauth-client.mdx Outdated
@ask-bonk

ask-bonk Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

PR Review Summary

Actions taken:

  • Fixed title typo: genrationgeneration
  • Added labels: documentation, content:edit
  • Posted 1 inline suggestion

Assessment: 1 style issue needs addressing before merge.

Issues found

MEDIUMsrc/content/docs/fundamentals/oauth/create-an-oauth-client.mdx:29

  • Sentence case regression: The step list item - Token Authentication method breaks sentence case (only proper nouns should be capitalized). Suggested reverting to - Token authentication method.

What the PR changes

Clarifies the OAuth client creation steps in the Dashboard tab:

  • Expands step 6 to list specific optional fields and notes they are required before making a client public
  • Adds a requirement that all clients must have at least one scope
  • Renames the "Required fields" section to "Required fields for public clients" and adds an introductory sentence for clarity
  • Minor capitalization adjustments to field names

Out-of-scope notes

The documentation checklist in the PR body remains unchecked. For a minor docs edit like this, a changelog entry is likely unnecessary, but the author should confirm the style guide checkbox.

github run

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Comment thread src/content/docs/fundamentals/oauth/create-an-oauth-client.mdx Outdated
@irvinebroque

Copy link
Copy Markdown
Contributor

/bonk update this pr to make @AdamBouhmad codeowner for the file being edited

Co-authored-by: irvinebroque <irvinebroque@users.noreply.github.com>
@ask-bonk

ask-bonk Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Updated the PR to make @AdamBouhmad a codeowner for the OAuth file being edited.

Change made:
Added a new CODEOWNERS entry for /src/content/docs/fundamentals/oauth/ that includes @AdamBouhmad alongside the existing owners (@dcpena and @cloudflare/product-owners). This keeps the broader fundamentals/ ownership intact while giving Adam specific ownership over the OAuth docs.

github run

@github-actions github-actions Bot requested review from a team and kodster28 as code owners June 14, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:edit Request for content edits documentation Documentation edits product:fundamentals size/s

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants