Add Load Balancing documentation updates#31583
Open
ngayerie wants to merge 3 commits into
Open
Conversation
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
PR Review SummaryVerdict: 4 issues need fixing before merge. Posted inline suggestions for all. Issues FlaggedHIGH — Broken link in LOW — Inconsistent horizontal rules:
What the PR ChangesAdds 12 documentation clarifications across 9 files covering:
Labels Applied
|
72b2bb3 to
69bef14
Compare
Document undocumented behaviors and configuration guidance across Load Balancing, health monitors, and Spectrum: 1. Planned maintenance: existing connections not terminated on unhealthy 2. Monitors: IPv4/IPv6 probe behavior 3. Adaptive routing: failover across pools geo-steering limitation 4. Monitor retries: immediate retry timing, not interval-based 5. Pools: endpoint address uniqueness constraint 6. Adaptive routing: HTTP/2 GOAWAY frame handling 7. FAQ: analytics 5s cache behavior with and without custom rules 8. Spectrum: session affinity workaround (IP fallback) 9. Private network: public LB with Tunnel off-ramp pattern 10. Custom rules: pool override failover behavior 11. Health checks: interval timing grouping behavior 12. Custom rules: DNS-only LB forced to proxied with HTTP rules Resolves DEE-3631
69bef14 to
001955e
Compare
Contributor
Contributor
Review⏸️ Automatic reviews for this PR are paused. This PR has already received 2 automatic reviews. To run another review, a codeowner can comment
✅ No issues found in commit Code ReviewThis code review is in beta and may not always be helpful — use your judgment. ✅ No code review issues found. Style Guide Review✅ No style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Collaborator
Author
|
Hi @ncrouch-cflare |
ncrouch-cflare
requested changes
Jun 24, 2026
- create-pool: clarify endpoint uniqueness (port or virtual network) - load-balancing-rules: remove inaccurate pool override failover section - spectrum: rename 'Session affinity workaround' and align phrasing with 'session affinity by cookie and client IP fallback' feature name - private-network: remove redundant Tunnel off-ramp section (already covered in the existing Tunnels section below) - health-checks: remove vague interval timing paragraph - create-monitor: active voice, 'five' not '5', timeout-only triggers
Per reviewer feedback, this behavior description was inaccurate.
Collaborator
Author
|
re-opening to trigger CI tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation updates covering undocumented behaviors and configuration guidance across Load Balancing, monitors, health checks, pools, and Spectrum.
Source: Wiki review page
Changes (9 files, +64/-1)
load-balancing/pools/create-pool.mdxload-balancing/additional-options/load-balancing-rules/index.mdxload-balancing/additional-options/planned-maintenance.mdxload-balancing/monitors/create-monitor.mdxload-balancing/monitors/index.mdxspectrum/about/load-balancer.mdxload-balancing/private-network/index.mdxload-balancing/understand-basics/adaptive-routing.mdxhealth-checks/index.mdxReview feedback addressed
Stats
9 files changed, +64 insertions, -1 deletion
Resolves DEE-3631