[Python] Remove all to_js usage from bindings examples#31636
Open
ryanking13 wants to merge 1 commit into
Open
Conversation
Contributor
Review🚨 1 critical, Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Critical (1)
Warnings (5)
Style Guide Review✅ No style-guide issues found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
irvinebroque
approved these changes
Jun 23, 2026
ryanking13
commented
Jun 23, 2026
Contributor
Author
There was a problem hiding this comment.
This should be merged after cloudflare/workers-py#138 is merged and released
| api_url2 = api_url | ||
|
|
||
| target = urlparse(api_url2) | ||
| request = Request.new(api_url2, request) |
Contributor
Author
Contributor
There was a problem hiding this comment.
Request has a clone method, maybe we can give it an optional URL argument?
Contributor
dom96
approved these changes
Jun 24, 2026
dom96
left a comment
Contributor
There was a problem hiding this comment.
Nice, thanks for fixing these!
| return await fetch(new_request) | ||
| except Exception as e: | ||
| return Response.new({"error": str(e)}, status=500) | ||
| return Response(str(e), status=500) |
Contributor
There was a problem hiding this comment.
I wonder if the idea here is to return json. Maybe you can use Response.json here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes remaining
pyodide.ffi.to_jsusage from workers bindings documentation. Python workers team has improved the SDK so that users does not have to manually convert Python objects into JS-serializable object before passing to RPC boundary.Screenshots (optional)
Documentation checklist