fix: isolate API token from user code scope - #25
Merged
Conversation
Move user code execution from evaluate() into a separate private #run() method. The apiToken parameter is only accessible within evaluate(), where it gets captured by the cloudflare.request() closure and stored on a private class field. User code in #run() can access the cloudflare helper but not the raw token value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
evaluate(apiToken), meaningapiTokenwas in the lexical scope and directly readable (confirmed during security audit)#run()method whereapiTokenis not in scopecloudflare.request()closure and stored via a#privateclass field, inaccessible to user code/graphqlinstead of/client/v4/graphql)Test plan
cloudflare.request()still works (token is properly used for auth)apiToken—typeof apiTokenshould be'undefined'this.#cloudflareis not accessible from user code (private field)accountIdis still accessible from user code (module-level const)