Fix authentication bypass in type3 RateLimitedAttester.VerifyRequest - #69
Merged
Conversation
VerifyRequest mapped verification failures to the success sentinel by returning nil instead of the error. When innerVerifyRequest reported an invalid client signature, and when ecdsa.CreateKey failed, the function returned nil. Propagate the errors (return err) and add a negative test that feeds an invalid signature into VerifyRequest and asserts a non-nil error.
thibmeu
self-requested a review
June 1, 2026 14:55
thibmeu
approved these changes
Jun 1, 2026
thibmeu
left a comment
Member
There was a problem hiding this comment.
looks good
one thing to note: given type3 never got standardised or added in privacy pass token registry, iot's technically not 0x0003. probably a not for myself down the liney
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VerifyRequest mapped verification failures to the success sentinel by returning nil instead of the error. When innerVerifyRequest reported an invalid client signature, and when ecdsa.CreateKey failed, the function returned nil. Propagate the errors (return err) and add a negative test that feeds an invalid signature into VerifyRequest and asserts a non-nil error.