Skip to content

Add 2024-03-26 entry point to workers-types#1904

Open
IgorMinar wants to merge 1 commit into
mainfrom
igorminar/workers-types-2024-03-26
Open

Add 2024-03-26 entry point to workers-types#1904
IgorMinar wants to merge 1 commit into
mainfrom
igorminar/workers-types-2024-03-26

Conversation

@IgorMinar

@IgorMinar IgorMinar commented Mar 27, 2024

Copy link
Copy Markdown
Contributor

adding a new entry point since the last one is from July 2023

@IgorMinar IgorMinar requested review from a team as code owners March 27, 2024 00:00
@IgorMinar IgorMinar requested review from jp4a50 and mikea March 27, 2024 00:00
@github-actions

github-actions Bot commented Mar 27, 2024

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@IgorMinar

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Mar 27, 2024
@IgorMinar

Copy link
Copy Markdown
Contributor Author

recheck

@kentonv

kentonv commented Mar 27, 2024

Copy link
Copy Markdown
Member

Note that RPC is scheduled for 2024-04-03. Will we be able to add another entrypoint next week?

@IgorMinar

Copy link
Copy Markdown
Contributor Author

I see, I suggest that we then wait and release the 2024-04-03 entrypoint instead. (There is a cost to having too many entrypoints as it bloats the npm package.)

@mrbbot

mrbbot commented Mar 28, 2024

Copy link
Copy Markdown
Contributor

Will we be able to add another entrypoint next week?

We shouldn't actually need to cut a new date for them. Whilst calling RPC methods on the client requires the rpc flag and new compat date, AFAIK using the classes from cloudflare:workers doesn't, and so these types should be accessible regardless of your compat date. Arguably the Fetcher/Service/DurableObjectNamespace types shouldn't accept a type parameter with the old compat date, but this probably doesn't matter too much.

@kentonv

kentonv commented Mar 29, 2024

Copy link
Copy Markdown
Member

Oh good point... Yeah, the "rpc" compat flag doesn't actually impact the types at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants