kj::Rc<Membrane>#2029
Draft
mikea wants to merge 1 commit into
Draft
Conversation
mikea
added a commit
to capnproto/capnproto
that referenced
this pull request
Apr 16, 2024
All real membrane implementations already are. Explicit refcounting makes reasoning about lifetime much easier. You could argue that this style makes memory leaks more possible, but arguably this is the right tradeoff to make instead of lifetime issue. I'm seeking for initial feedback (yay/nay) before I spend too much time cleaning this up. Corresponding downstream pull requests are: cloudflare/workerd#2029 and EW/7744
mikea
added a commit
to capnproto/capnproto
that referenced
this pull request
Aug 29, 2025
All real membrane implementations already are. Explicit refcounting makes reasoning about lifetime much easier. You could argue that this style makes memory leaks more possible, but arguably this is the right tradeoff to make instead of lifetime issue. I'm seeking for initial feedback (yay/nay) before I spend too much time cleaning this up. Corresponding downstream pull requests are: cloudflare/workerd#2029 and EW/7744
mikea
added a commit
to capnproto/capnproto
that referenced
this pull request
Aug 29, 2025
All real membrane implementations already are. Explicit refcounting makes reasoning about lifetime much easier. You could argue that this style makes memory leaks more possible, but arguably this is the right tradeoff to make instead of lifetime issue. I'm seeking for initial feedback (yay/nay) before I spend too much time cleaning this up. Corresponding downstream pull requests are: cloudflare/workerd#2029 and EW/7744
mikea
added a commit
to capnproto/capnproto
that referenced
this pull request
Sep 17, 2025
All real membrane implementations already are. Explicit refcounting makes reasoning about lifetime much easier. You could argue that this style makes memory leaks more possible, but arguably this is the right tradeoff to make instead of lifetime issue. I'm seeking for initial feedback (yay/nay) before I spend too much time cleaning this up. Corresponding downstream pull requests are: cloudflare/workerd#2029 and EW/7744
ecef9b7 to
37bae23
Compare
|
The generated output of Full Type Diff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.