Skip to content

Add a test for Workers SDK issue#2166

Open
kossnocorp wants to merge 1 commit into
cloudflare:mainfrom
kossnocorp:join-squash
Open

Add a test for Workers SDK issue#2166
kossnocorp wants to merge 1 commit into
cloudflare:mainfrom
kossnocorp:join-squash

Conversation

@kossnocorp

Copy link
Copy Markdown

This PR isn't meant to be merged, yet it might be useful depending on how the maintainers would like to approach the problem.

I opened it because of the Workers SDK issue, which causes unexpected behavior of JOIN with the same column names that I'm trying to fix. I need proof of the behavior, and hopefully, this PR will allow me to demonstrate the passing test result.

The Workers SDK issue: cloudflare/workers-sdk#3160

A Workers SDK PR with a similar test that is failing: cloudflare/workers-sdk#5917

@kossnocorp kossnocorp requested review from a team as code owners May 25, 2024 21:23
@kossnocorp kossnocorp requested review from ObsidianMinor and mikea May 25, 2024 21:23
@github-actions

github-actions Bot commented May 25, 2024

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kossnocorp

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@kossnocorp

kossnocorp commented May 25, 2024

Copy link
Copy Markdown
Author

Just in case it's helpful, here are the tests passing on my machine:

image

github-actions Bot added a commit that referenced this pull request May 25, 2024
The issue: cloudflare/workers-sdk#3160

The test is passing and it is proof of the expected behavior that Workers SDK doesn't match.
@mikea mikea self-requested a review May 28, 2024 15:50
@kentonv kentonv requested a review from geelen May 29, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants