Adds more information to script will never generate a response errors#2239
Adds more information to script will never generate a response errors#2239mikenomitch wants to merge 1 commit into
Conversation
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
|
@jasnell bumping this for re-review now that the URL I added is up? |
jasnell
left a comment
There was a problem hiding this comment.
LGTM but let's have an internal pr that pulls this in and verifies than none of the internal tests are depending on the old error message.
|
|
||
| static constexpr auto scriptWillNeverGenerateResponseErr = | ||
| "The script will never generate a response. Request response relies on " | ||
| "a Promise that will never be resolved during the Request's lifetime. " |
There was a problem hiding this comment.
A lot of developers don't even really know what a Promise is.
Maybe the language should be something like:
The runtime has detected that this request will hang forever, so the request has been canceled.
Adds a bit more information to the logs for "script will never generate a response" including a URL to upcoming docs.
This should only be merged after the docs changes here get in.