repro for stack leaking bug#4783
Open
Caio-Nogueira wants to merge 4 commits into
Open
Conversation
Adds tests that verify that stacks are not preserved by default across RPC boundaries, but are preserved when the caller indicates that the scope is trusted.
Not just thrown errors but also returned serialized errors.
38a68d2 to
189b981
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a comprehensive deep dive against the stack leaking bug, here's our findings:
We are not returning errors, always re throwing and catching
Stack trace on Sentry is combined from two services
We've updated your test in this branch @jasnell to try to reproduce this (but we can't). Both Foo and Bar are actors.
test -> Foo.fetch1 -> sets alarm
alarm -> Foo.foo() -> Bar.bar() -> Bar.blah()