Adds compat flag for changing behaviour of validator.#5636
Open
dom96 wants to merge 1 commit into
Open
Conversation
jasnell
approved these changes
Dec 3, 2025
jasnell
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but is a compat flag the right thing for this? Will this be turned on selectively by only certain workers?
Collaborator
|
I don't understand why we want a compat flag for this |
anonrig
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This compat flag will be used to roll out a change in the validator which will enable it to return capnp instead of JSON, as well as return the original WorkerBundle with changes made to it, instead of only permitting EWC to make changes to the deployed WorkerBundle.