Skip to content

Removes deprecated built-in Python package support.#6114

Open
dom96 wants to merge 1 commit into
mainfrom
dominik/remove-package-built-in-code
Open

Removes deprecated built-in Python package support.#6114
dom96 wants to merge 1 commit into
mainfrom
dominik/remove-package-built-in-code

Conversation

@dom96

@dom96 dom96 commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Packages in Python Workers are now supported via pywrangler (and vendoring) so the built-in packages mechanism is no longer necessary. This PR removes (most of) the code for this mechanism and deprecates this feature.

@dom96 dom96 requested review from hoodmane and ryanking13 February 19, 2026 15:06
@dom96 dom96 requested review from a team as code owners February 19, 2026 15:06
Comment thread src/cloudflare/internal/pipeline-transform.ts
Comment thread src/node/internal/internal_assert.ts
Comment thread src/node/internal/internal_url.ts
Comment thread src/node/http2.ts
Comment thread src/node/punycode.ts
Comment thread src/pyodide/internal/snapshot.ts
Comment on lines +5533 to +5534
co_await server::fetchPyodidePackages(
pythonConfig, pythonConfig.pyodidePackageManager, {}, release, network, timer);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need fetchPyodidePackages anymore?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed like it, I started getting errors about missing crypto when I removed it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment?

@dom96 dom96 force-pushed the dominik/remove-package-built-in-code branch from 7ed69b5 to 5a28942 Compare February 19, 2026 16:13
Comment thread src/pyodide/internal/snapshot.ts
Comment thread src/workerd/io/worker-source.h
@dom96 dom96 force-pushed the dominik/remove-package-built-in-code branch from 5a28942 to 13de0c3 Compare February 24, 2026 11:45
@ask-bonk

ask-bonk Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

@dom96 Bonk workflow was cancelled.

View workflow run · To retry, trigger Bonk again.

@dom96 dom96 force-pushed the dominik/remove-package-built-in-code branch from 13de0c3 to 2883c72 Compare April 28, 2026 09:31
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@dom96 dom96 force-pushed the dominik/remove-package-built-in-code branch from 2883c72 to e0bc929 Compare April 28, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants