[wrangler] fix: don't require private credential when reusing an existing Secrets Store secret#14362
Merged
edmundhung merged 2 commits intoJun 23, 2026
Conversation
…ting Secrets Store secret `containers registries configure` now checks whether the target Secrets Store secret already exists before resolving the private credential. If it exists, the secret is reused by reference, so the credential no longer needs to be supplied via stdin or an interactive prompt. The new-secret and FedRAMP inline paths are unchanged; the interactive secret prompt now appears only when creating a new secret.
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
nikitassharma
approved these changes
Jun 18, 2026
5 tasks
jamesopstad
approved these changes
Jun 22, 2026
workers-devprod
approved these changes
Jun 22, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Merged
petebacondarwin
pushed a commit
that referenced
this pull request
Jun 23, 2026
…ting Secrets Store secret (#14362)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #CC-7994, Issue 14356
containers registries configurenow checks whether the target Secrets Store secret already exists before resolving the private credential. If it exists, the secret is reused by reference, so the credential no longer needs to be supplied via stdin or an interactive prompt. The new-secret and FedRAMP inline paths are unchanged; the interactive secret prompt now appears only when creating a new secret.A picture of a cute animal (not mandatory, but encouraged)