[wrangler] fix(d1): escape migrationsTableName and filenames in SQLite queries#14394
Merged
jamesopstad merged 2 commits intoJun 23, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 2f4f748 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
alsuren
approved these changes
Jun 23, 2026
alsuren
left a comment
Contributor
There was a problem hiding this comment.
Seems correct, and matches how we're doing things in dumpSql.ts. Also tested locally.
Ship it.
jamesopstad
approved these changes
Jun 23, 2026
workers-devprod
approved these changes
Jun 23, 2026
workers-devprod
left a comment
Contributor
There was a problem hiding this comment.
Codeowners reviews satisfied
Contributor
|
Hi @Partha-Shankar. Thanks for the PR. Please could you add a patch changeset and then we'll be able to get this merged? |
jamesopstad
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two SQL escaping issues in D1 migrations.
What changed
Escape
migrationsTableNameD1 migration queries previously interpolated
migrationsTableNamedirectly into SQLite statements.This change escapes migration table identifiers using SQL-standard double quotes before constructing queries.
Affected queries include:
CREATE TABLESELECTINSERTEscape migration filenames
Migration filenames are inserted into SQL string literals when recording applied migrations.
Filenames containing apostrophes could generate invalid SQL. This change escapes single quotes before insertion.
Example:
becomes:
when used inside SQL string literals.
Why
These changes improve the robustness of D1 migrations by:
The changes are fully backward compatible and do not alter existing migration behavior.
🦦