Skip to content

Improve the error messaging when the user provides neither an entry point nor an asset directory#8534

Merged
petebacondarwin merged 2 commits into
mainfrom
pbd/wrangler/update-missing-main-message
Mar 19, 2025
Merged

Improve the error messaging when the user provides neither an entry point nor an asset directory#8534
petebacondarwin merged 2 commits into
mainfrom
pbd/wrangler/update-missing-main-message

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor message change
  • Wrangler V3 Backport

@petebacondarwin petebacondarwin added the ci:e2e Run wrangler + vite-plugin E2E tests on a pull request label Mar 17, 2025
@petebacondarwin petebacondarwin requested a review from a team as a code owner March 17, 2025 20:32
@changeset-bot

changeset-bot Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6bc4ed

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod mentioned this pull request Mar 17, 2025
Merged
@github-actions

github-actions Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-wrangler-8534

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8534/npm-package-wrangler-8534

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-wrangler-8534 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workers-bindings-extension-8534 -O ./cloudflare-workers-bindings-extension.0.0.0-v815872514.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v815872514.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-create-cloudflare-8534 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-kv-asset-handler-8534

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-miniflare-8534

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-pages-shared-8534

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-unenv-preset-8534

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-vite-plugin-8534

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-vitest-pool-workers-8534

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workers-editor-shared-8534

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workers-shared-8534

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13952534111/npm-package-cloudflare-workflows-shared-8534

Note that these links will no longer work once the GitHub Actions artifact expires.

wrangler@4.2.0 includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 4.20250317.1
workerd 1.20250317.0 1.20250317.0
workerd --version 1.20250317.0 2025-03-17

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@github-project-automation github-project-automation Bot moved this to Untriaged in workers-sdk Mar 17, 2025
emily-shen
emily-shen reviewed Mar 19, 2025
View reviewed changes
Comment thread packages/wrangler/src/__tests__/deploy.test.ts Outdated
@github-project-automation github-project-automation Bot moved this from Untriaged to Approved in workers-sdk Mar 19, 2025
@petebacondarwin petebacondarwin force-pushed the pbd/wrangler/update-missing-main-message branch from 523d952 to ebdf09d Compare March 19, 2025 14:53
emily-shen
emily-shen reviewed Mar 19, 2025
View reviewed changes
Comment thread packages/wrangler/src/deployment-bundle/entry.ts Outdated
emily-shen
emily-shen reviewed Mar 19, 2025
View reviewed changes
Comment thread packages/wrangler/src/__tests__/deploy.test.ts Outdated
dario-piotrowicz
dario-piotrowicz reviewed Mar 19, 2025
View reviewed changes
Comment thread packages/wrangler/src/__tests__/deploy.test.ts Outdated
Comment thread packages/wrangler/src/deployment-bundle/entry.ts Outdated
@petebacondarwin petebacondarwin force-pushed the pbd/wrangler/update-missing-main-message branch from 6c47204 to d6bc4ed Compare March 19, 2025 17:09
@petebacondarwin petebacondarwin merged commit 62d5471 into main Mar 19, 2025
@petebacondarwin petebacondarwin deleted the pbd/wrangler/update-missing-main-message branch March 19, 2025 21:53
@github-project-automation github-project-automation Bot moved this from Approved to Done in workers-sdk Mar 19, 2025
@workers-devprod workers-devprod mentioned this pull request Mar 19, 2025
Merged
petebacondarwin added a commit that referenced this pull request Mar 20, 2025
@workers-devprod @petebacondarwin
Backport #8534 to Wrangler v3 (#8535)
6f8e892 
* Improve the error messaging when the user provides neither an entry point nor an asset directory

* copy edits

---------

Co-authored-by: Peter Bacon Darwin <pbacondarwin@cloudflare.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz left review comments
@emily-shen emily-shen emily-shen left review comments
@penalosa penalosa penalosa approved these changes

Assignees

No one assigned

Labels

ci:e2e Run wrangler + vite-plugin E2E tests on a pull request

Projects

workers-sdk
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petebacondarwin @penalosa @dario-piotrowicz @emily-shen @workers-devprod