[examples.percentiles] Annotate and Improve Findability of How to Configure Percentiles - #1199
[examples.percentiles] Annotate and Improve Findability of How to Configure Percentiles#1199conallob wants to merge 2 commits into
Conversation
|
@manugarg Friendly ping? |
c577e72 to
8f52c62
Compare
|
Ping? |
manugarg
left a comment
There was a problem hiding this comment.
Unreviewable because of crazy diffs. But if we keep them aside, I am wondering what's the use of such PRs. We can't create example for everything and I've not seen anybody run into these problems before. There is a whole doc on configuring percentiles: https://cloudprober.org/docs/how-to/percentiles/
|
I could move these edits to the doc, instead of putting them in an example. The issue I'm trying to address is that someone short on time might take the documented config example, drop it into their Cloudprober and then wonder why their latency data doesn't work for them. I may have fallen into this trap myself |
405c628 to
d3f9980
Compare
|
Sorry about that, I had managed to get myself into git rebase hell. FIxed now |
|
Friendly ping? The diff is now +14 lines following the rebae |
Annotate the scope of the percentiles example in https://cloudprober.org/docs/how-to/percentiles/ , as a reminder for
readers to not blindly C&P the example
Create an explicit example config under
examples/percentiles/