NodeUtils: allow YAML list to declare node groups#438
Conversation
rack5:
- 'example[200-205]' # some comment about example[200-205]
- 'example245'
- 'example300,example[401-406]'
griznog$ nodeset -f @racks:rack5
example[200-205,245,300,401-406]
There was a problem hiding this comment.
Thanks for your patch. It looks good, could you also:
- Add a test for that in
tests/NodeSetGroupTest.py, at the end ofYAMLGroupLoaderTestclass - A tiny example in the doc in
doc/sphinx/config.rst
Could you also edit your commit message and make it looks similar to 9b3a239 by example, meaning:
- A title with a prefix :
NodeUtils: - A small title (less than 70 char):
allow YAML list to declare node groups - A blank line
- A sentence explaining the change more in detail
|
Thanks for the changes. They looks good! However, when I was talking about the commit message, I was really talking about the commit message of the unique commit you should have in this branch. |
If group is a list, ','.join to make a string before returning _list_node().
|
Clearly I'm lost with the git squash part of this, I don't understand why I wound up with the second merge commit? Lots of "first time doing X" for me in this process, thanks for being patient. |
|
Thanks @griznog , I managed the squash things. Thanks for your patch! |
I'm hoping to keep my squash in the garden :) |
Allow the use of YAML list syntax when defining node groups.