Worker: deprecate old EventHandler method signatures (#358)#496
Merged
Conversation
30e2fe3 to
dbf3857
Compare
Old EventHandler signatures (eg. ev_read(self, worker)) have been deprecated since 1.8. This patch adds DeprecationWarnings for 1.9. Also deprecating Worker.current_* variables in the documentation. New EventHandler's method arguments should be used instead. Also updated all tests that were still relying on old signatures. Closes clustershell#358.
dbf3857 to
5c02bd4
Compare
degremont
approved these changes
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old EventHandler signatures (eg. ev_read(self, worker)) have been deprecated since 1.8. This patch adds DeprecationWarnings for 1.9.
Also deprecating Worker.current_* variables in the documentation.
New EventHandler's method arguments should be used instead.
Also updated all tests that were still relying on old signatures.
Closes #358.