NodeUtils: do not pass stdin to group upcalls#581
Merged
Conversation
Some commands consume stdin when they shouldn't, but we shouldn't have been giving stdin to upcalls in the first place. Reported-by: Kilian Cavalotti <kilian@stanford.edu>
degremont
approved these changes
Feb 8, 2025
degremont
left a comment
Collaborator
There was a problem hiding this comment.
Maybe we should add a line in the right place in documentation to clarify that?
Otherwise, LGTM!
Collaborator
Author
|
Hmm, documentation doesn't seem to say much about how upcalls are executed currently, I think it's fine as it is.
|
Collaborator
|
Actually you're right, this is not that important. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some commands consume stdin when they shouldn't, but we shouldn't have been giving stdin to upcalls in the first place.
Reported-by: Kilian Cavalotti kilian@stanford.edu
replaces #580