Skip to content

fix: support windows specific zip mime type for template uploads#15442

Merged
ethanndickson merged 1 commit into
mainfrom
ethan/fix-windows-zip
Nov 8, 2024
Merged

fix: support windows specific zip mime type for template uploads#15442
ethanndickson merged 1 commit into
mainfrom
ethan/fix-windows-zip

Conversation

@ethanndickson

@ethanndickson ethanndickson commented Nov 8, 2024

Copy link
Copy Markdown
Member

image
Despite being encoded the same, the API was previously rejecting zip files with this MIME type.

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson requested a review from mtojek November 8, 2024 06:59
@ethanndickson ethanndickson marked this pull request as ready for review November 8, 2024 06:59

@mtojek mtojek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Nice spotting 👍

@ethanndickson ethanndickson merged commit f7cbf5d into main Nov 8, 2024
@ethanndickson ethanndickson deleted the ethan/fix-windows-zip branch November 8, 2024 07:24
stirby pushed a commit that referenced this pull request Dec 11, 2024
)

![image](https://github.com/user-attachments/assets/15ae6dc4-84a3-4c20-b603-ed38cc14a250)
Despite being encoded the same, the API was previously rejecting zip
files with this MIME type.

(cherry picked from commit f7cbf5d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants