Skip to content

fix(enterprise/coderd/license): suppress AI Governance seat-count error for not-entitled licenses #25885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SasSwart merged 1 commit into from
Jun 4, 2026
Merged

fix(enterprise/coderd/license): suppress AI Governance seat-count error for not-entitled licenses #25885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions enterprise/coderd/license/license.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,9 +494,10 @@ func LicensesEntitlements(
feature := entitlements.Features[codersdk.FeatureAIGovernanceUserLimit]
switch {
case feature.Entitlement == codersdk.EntitlementNotEntitled:
// If the limit is not set
entitlements.Errors = append(entitlements.Errors,
fmt.Sprintf("Your deployment has %d active AI Governance seats but the license is not entitled to this feature.", actual))
// Not-entitled deployments can accumulate phantom ai_seat_state
// rows from prior Gateway testing or Task usage. Surfacing an
// error here is alarming and inactionable for customers who
// never purchased the AI Governance addon.
case feature.Entitlement == codersdk.EntitlementGracePeriod && feature.Limit != nil:
entitlements.Warnings = append(entitlements.Warnings,
fmt.Sprintf(
Expand Down
53 changes: 53 additions & 0 deletions enterprise/coderd/license/license_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,6 +1146,59 @@ func TestEntitlements(t *testing.T) {
require.NotContains(t, warning, "over the limit")
}
})

t.Run("NotEntitledSuppressed", func(t *testing.T) {
t.Parallel()

const activeSeatCount int64 = 42

ctrl := gomock.NewController(t)
mDB := dbmock.NewMockStore(ctrl)

// Premium license without the AI Governance addon.
licenseOpts := (&coderdenttest.LicenseOptions{
FeatureSet: codersdk.FeatureSetPremium,
NotBefore: dbtime.Now().Add(-time.Hour).Truncate(time.Second),
GraceAt: dbtime.Now().Add(time.Hour * 24 * 60).Truncate(time.Second),
ExpiresAt: dbtime.Now().Add(time.Hour * 24 * 90).Truncate(time.Second),
}).
UserLimit(100)

lic := database.License{
ID: 1,
JWT: coderdenttest.GenerateLicense(t, *licenseOpts),
Exp: licenseOpts.ExpiresAt,
}

mDB.EXPECT().
GetUnexpiredLicenses(gomock.Any()).
Return([]database.License{lic}, nil)
mDB.EXPECT().
GetActiveUserCount(gomock.Any(), false).
Return(int64(1), nil)
mDB.EXPECT().
GetActiveAISeatCount(gomock.Any()).
Return(activeSeatCount, nil)
mDB.EXPECT().
GetTotalUsageDCManagedAgentsV1(gomock.Any(), gomock.Any()).
Return(int64(0), nil)
mDB.EXPECT().
GetTemplatesWithFilter(gomock.Any(), gomock.Any()).
Return([]database.Template{}, nil)

entitlements, err := license.Entitlements(context.Background(), mDB, 1, 0, coderdenttest.Keys, all)
require.NoError(t, err)
require.True(t, entitlements.HasLicense)

// The not-entitled case should not produce errors about
// AI Governance seat counts.
for _, e := range entitlements.Errors {
require.NotContains(t, e, "AI Governance seats")
}
for _, w := range entitlements.Warnings {
require.NotContains(t, w, "AI Governance seats")
}
})
})
}

Expand Down
Loading