Clone options#259
Merged
Merged
Conversation
Contributor
|
Nice catch! Can confirm. I tested it at the time and thought it worked but I guess I got confused. |
nhooyr
approved these changes
Sep 24, 2020
nhooyr
left a comment
Contributor
There was a problem hiding this comment.
Thanks for contributing @abursavich!
|
There are still 2 more instances of this. |
Contributor
|
Good eye @icholy, I've made note of those in my TODO and will have a PR up to fix shortly. |
nhooyr
added a commit
that referenced
this pull request
Jan 9, 2021
Thank you @icholy for identifying these in #259 (comment)
nhooyr
added a commit
that referenced
this pull request
Jan 9, 2021
Thank you @icholy for identifying these in #259 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opts = &*optsis a no-op.See: https://staticcheck.io/docs/checks#SA4001