fix(CCarousel): clear cycle timeouts reliably and scope effects#467
Merged
Conversation
- always clear the pending cycle timeout before scheduling a new one, so timeouts no longer stack when pause is disabled - clear the pending timeout on unmount - run the items-count effect only when children change and register the scroll listener once instead of on every render
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
pause={false}.cycle()relied on_pause()to clear the previous timeout, but_pauseis gated on thepauseprop — withpause={false}everycycle()call (mouse leave, slide change) scheduled an additional timeout without clearing the previous one.setActiveon an unmounted component.windowscroll listener was removed/re-added on every render.Changes
clearCycleTimeout()and call it unconditionally at the start ofcycle();_pausekeeps its prop-gated semantics for hover.[children]and register the scroll listener once ([]— the handler only touches refs and state setters).Tests
2 new regression tests using
jest.getTimerCount(): repeated mouse-leave withpause={false}does not grow the pending timer count, and unmount releases the pending cycle timeout. Both fail againstmain, pass with the fix. Full suite: 127 suites / 350 tests green, no snapshot changes.