content_encoding: give a clear error on multi-member gzip#22172
Open
HwangRock wants to merge 1 commit into
Open
content_encoding: give a clear error on multi-member gzip#22172HwangRock wants to merge 1 commit into
HwangRock wants to merge 1 commit into
Conversation
A gzip Content-Encoding response holding more than one gzip member made curl decode the first member and then fail the transfer with a bare CURLE_WRITE_ERROR and no hint about the cause. Detect the trailing member and fail with a message that explains what happened. Ref: curl#22156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the discussion in #22156.
Rather than decoding multi-member gzip responses, this keeps curl failing
on them as discussed there, but swaps the bare CURLE_WRITE_ERROR for a
message that says what actually happened.
When inflate reaches the end of the first gzip member and the next bytes
are another gzip header (1f 8b), curl now fails with:
instead of the generic "Failed writing received data to disk/application",
which gave no hint about the cause.
Adds test 2305.
Ref: #22156