fix: wasm_memory_threshold is now bounded by 256TiB#304
Merged
Conversation
schneiderstefan
approved these changes
Jun 26, 2026
mraszyk
commented
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the maximum allowed value for wasm_memory_threshold to match that of wasm_memory_limit which also restricts (with a different semantics) wasm memory usage and thus using the same maximum allowed value makes sense. Both values are now specified to be up to
2^{48}bytes (256 TiB), reflecting the replica PR forwasm_memory_thresholdand the actual maximum allowed value forwasm_memory_limitalready in place (2^{48}bytes rather than2^{48}-1bytes).