Skip to content

Handle errors #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sungwoncho merged 1 commit into from
Oct 12, 2025
Merged

Handle errors #693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/cli/cmd/sync/sync.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1060,7 +1060,9 @@ func newRun(ctx context.DnoteCtx) infra.RunEFunc {
}
}

tx.Commit()
if err := tx.Commit(); err != nil {
return errors.Wrap(err, "committing transaction")
}

log.Success("success\n")

Expand Down
4 changes: 3 additions & 1 deletion pkg/cli/infra/init.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,9 @@ func InitSystem(ctx context.DnoteCtx) error {
return errors.Wrapf(err, "initializing system config for %s", consts.SystemLastSyncAt)
}

tx.Commit()
if err := tx.Commit(); err != nil {
return errors.Wrap(err, "committing transaction")
}

return nil
}
Expand Down