This repository was archived by the owner on Jan 21, 2026. It is now read-only.
Set the temp file extension based on the content type - #208
Merged
Conversation
jimmylewis
reviewed
Sep 3, 2019
jimmylewis
reviewed
Sep 3, 2019
…content type for json
jimmylewis
reviewed
Sep 3, 2019
jimmylewis
reviewed
Sep 3, 2019
jimmylewis
reviewed
Sep 3, 2019
…equire an extension; pass in .tmp if we can't find a more appropriate one. Also moved a couple integration tests to be unit tests now that there was no file system dependency.
jodavis
reviewed
Sep 3, 2019
jimmylewis
reviewed
Sep 5, 2019
jimmylewis
reviewed
Sep 5, 2019
jimmylewis
reviewed
Sep 5, 2019
…sts for the failure conditions, renaming the success conditions
jimmylewis
approved these changes
Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #186.
When the content type we are sending is something known (
application/json,application/xml,text/xmlcurrently), we will create a temp file name with the appropriate file extension. If its anything else, we just use the defaultPath.GetTempFileName().