Add Aspire integration tests that build after scaffolding and enable them - #3806
Open
haileymck wants to merge 1 commit into
Open
Add Aspire integration tests that build after scaffolding and enable them#3806haileymck wants to merge 1 commit into
haileymck wants to merge 1 commit into
Conversation
…them Adds end-to-end Aspire integration tests that scaffold caching, database, and storage integrations and then build the resulting project, and enables the previously skipped Aspire integration tests across net8/9/10/11. Also fixes three underlying product bugs uncovered by the tests: - Aspire code-mod config layout in dotnet-scaffold.csproj - Aspire config-path resolution in AspireCodeModificationHelper - CLI exit-code propagation (IScaffoldRunner.RunAsync now returns Task<int>) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds end-to-end Aspire integration tests that scaffold caching, database, and storage integrations and then build the resulting project, verifying the scaffolded output actually compiles. Also enables the previously-skipped Aspire integration tests across
net8.0/net9.0/net10.0/net11.0.All 125 Aspire integration tests pass across all four TFMs (Caching 28, Database 28, Storage 69).
What changed
Tests
AspireCachingIntegrationTestsBase.cs,AspireDatabaseIntegrationTestsBase.cs,AspireStorageIntegrationTestsBase.cs: replaced placeholder templates with buildable AppHost + worker projects, added*_ScaffoldsAndBuildsE2E facts that scaffold the integration and then run a real build, and removed theSkipattributes so the suite runs.Helpers/ScaffoldCliHelper.cs: added Aspire template/project helpers;WriteAspireNuGetConfignow lets net8 Aspire fall through to the machine/repo dnceng feeds (like net9/10/11). Aspire packages are unpinned (IsVersionRequired=false) and need a live latest-version lookup, which nuget.org-only config can't serve; dncengdotnet-publicmirrors nuget.org and is CI-valid.Product fixes uncovered by the tests
dotnet-scaffold.csproj: corrected Aspire code-mod config layout so the config files are located at runtime.AspireCodeModificationHelper.cs: fixed Aspire config-path resolution.IScaffoldRunner.cs/ScaffoldRunner.cs/Program.cs: propagate the scaffold exit code (RunAsyncnow returnsTask<int>) so failures surface as a non-zero CLI exit code.Related issues
Umbrella:
Per-integration / per-TFM:
Testing