Add equals function to better calculate equality - #395
Merged
Conversation
| } | ||
|
|
||
| for (let i = 0; i < left.length; i++) { | ||
| if (equals(left[i], right[i]) === false) { |
There was a problem hiding this comment.
'equals' was used before it was defined.
| end | ||
|
|
||
| def compile({{:., _, [:erlang, op]}, _, [left, right]}, state) when op in [:+, :-, :*, :/, :==, :>, :<, :>=] do | ||
| def compile({{:., _, [:erlang, op]}, _, [left, right]}, state) when op in [:==, :===] do |
There was a problem hiding this comment.
Functions should have a @SPEC type specification.
| {ast, state} | ||
| end | ||
|
|
||
| def compile({{:., _, [:erlang, op]}, _, [left, right]}, state) when op in [:+, :-, :*, :/, :>, :<, :>=] do |
There was a problem hiding this comment.
Functions should have a @SPEC type specification.
| //TODO: Support more options, global is implied | ||
| //TODO: pattern cannot be list of strings | ||
| // TODO: Support more options, global is implied | ||
| // TODO: pattern cannot be list of strings |
|
|
||
| //TODO: Support more options, global is implied | ||
| //TODO: pattern cannot be list of strings | ||
| // TODO: Support more options, global is implied |
| //TODO: Support more options | ||
| //TODO: pattern cannot be list of strings | ||
| // TODO: Support more options | ||
| // TODO: pattern cannot be list of strings |
|
|
||
| //TODO: Support more options | ||
| //TODO: pattern cannot be list of strings | ||
| // TODO: Support more options |
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/elixirscript/elixirscript/pulls/395. |
Contributor
|
Question / nitpick, is :!= and :!== covered? (maybe its :/= and :=/=) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #382