Skip to content

fix: typing for python 3.9#32

Merged
chrisdickinson merged 7 commits into
extism:mainfrom
RedTTG:main
Jan 27, 2025
Merged

fix: typing for python 3.9#32
chrisdickinson merged 7 commits into
extism:mainfrom
RedTTG:main

Conversation

@RedTTG

@RedTTG RedTTG commented Jan 8, 2025

Copy link
Copy Markdown
Contributor

A quick fix to dd support for python 3.9 typing
Fixes: #31

Comment thread .github/workflows/ci.yaml Outdated
@RedTTG RedTTG requested a review from nilslice January 22, 2025 18:51

@nilslice nilslice left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you, @JustRedTTG !

I'd like @chrisdickinson to just do a quick pass before we merge, to be sure there aren't side effects here that I (a Python noob) am unaware of.

@RedTTG

RedTTG commented Jan 26, 2025

Copy link
Copy Markdown
Contributor Author

LGTM! Thank you, @JustRedTTG !

I'd like @chrisdickinson to just do a quick pass before we merge, to be sure there aren't side effects here that I (a Python noob) am unaware of.

Hey still waiting, everything should be good, I only changed like two lines of code haha. Waiting on @chrisdickinson then. Just came in to bump this

@chrisdickinson

Copy link
Copy Markdown

Aha, apologies! We only build the extism_sys native dep for python 3.10, so I'm kind of surprised to see the CI working against 3.9. I had meant to dig further into that this week –to make sure that python 3.9 worked generally– but got sidetracked.

@chrisdickinson

Copy link
Copy Markdown

(I've now re-loaded the context in my head: this project is on 3.8 so bumping things to 3.9 won't cause any new incompat issues. Merging!)

@chrisdickinson chrisdickinson merged commit 30e2829 into extism:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.9 typing incompatibility.

3 participants