Skip to content

Relax FSharp.Core requirement#64

Merged
dbrattli merged 1 commit into
fable-compiler:mainfrom
Zaid-Ajaj:relax-fsharp-core-requirement
Sep 4, 2022
Merged

Relax FSharp.Core requirement#64
dbrattli merged 1 commit into
fable-compiler:mainfrom
Zaid-Ajaj:relax-fsharp-core-requirement

Conversation

@Zaid-Ajaj

Copy link
Copy Markdown
Member

Using FSharp.Core ~> 4.7 means FSharp.Core >= 4.7.2 && FSharp.Core < 5.0.0

I don't believe Fable.Python needs this strict requirement, especially since F# 6.0 project already pull in FSharp.Core >= 6.0 so this PR relaxes this version requirement to make it just >= 4.7.2 which allows for wide compatibility with Fable projects

Noticed this from the dependencies of Fable.SimpleJson.Python

@dbrattli dbrattli left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@dbrattli dbrattli merged commit c64c6cd into fable-compiler:main Sep 4, 2022
@Zaid-Ajaj Zaid-Ajaj deleted the relax-fsharp-core-requirement branch September 4, 2022 13:03
@Zaid-Ajaj

Copy link
Copy Markdown
Member Author

@dbrattli can you please publish a new version of Fable.Python that includes this change? 🙏

@dbrattli

dbrattli commented Sep 5, 2022

Copy link
Copy Markdown
Collaborator

@Zaid-Ajaj have just released v0.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants