You have a graduate on the team and they have given you a pull request to review. The PR is a proof of concept for showing a list of players during the transfer window.
ℹ️ Please upload your code to a PRIVATE repo on GitHub and invite @andismith
- This is a proof of concept, the data is generated in-app. You do not need to hook it up to an API.
- You do not need to change the TypeScript / Prettier settings.
- You do not need to adjust the build.
Given the application you have received, please review the following requirements and adjust the code.
ℹ️ Please commit often so that we can see how you think
- TypeScript should be used throughout.
- Code should follow the DRY principle.
- The UI should fit within the device screen.
- The app should be performant. Assume the real app will need to fetch updates regularly to ensure the data is correct.
Is there anything else you could improve with the code?
Additionally, the team have asked for the following:
- The designer would like the items in the list to fade in.
- The QA engineer would like to see an End to End test for loading the app and clicking a player card.
- The CEO would like some haptic feedback when tapping go to player.
Fanalysis 2025