Skip to content

🌐 Add Korean translation for docs/ko/docs/project-generation.md#12157

Merged
alejsdev merged 7 commits into
fastapi:masterfrom
BORA040126:ko/docs/project-generation
Sep 7, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/project-generation.md#12157
alejsdev merged 7 commits into
fastapi:masterfrom
BORA040126:ko/docs/project-generation

Conversation

@BORA040126

Copy link
Copy Markdown
Contributor

Add Korean Translation for docs/ko/docs/project-generation.md

//i don't know much about anything

@github-actions github-actions Bot added the lang-all Translations label Sep 7, 2024
@github-actions

github-actions Bot commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

@BORA040126 BORA040126 changed the title Add Korean Translation for docs/ko/docs/project-generation.md Add Korean translation for docs/ko/docs/project-generation.md Sep 7, 2024

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi
i'm navtive korean who intersted in fastAPI
i left some review for you

Comment thread docs/ko/docs/project-generation.md Outdated
Comment thread docs/ko/docs/project-generation.md Outdated
rivise word to follow the guide
adjust the word more naturally.

@BORA040126 BORA040126 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revise word to follow the guide
adjust the word more naturally.

@github-actions

github-actions Bot commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

@sodaMelon

Copy link
Copy Markdown

revise word to follow the guide adjust the word more naturally.

good. and how about add emoji to in front of this PR subject like other Korean translation PR?

Comment thread docs/ko/docs/project-generation.md Outdated
Comment thread docs/ko/docs/project-generation.md Outdated
Comment thread docs/ko/docs/project-generation.md Outdated
Comment thread docs/ko/docs/project-generation.md Outdated
@sodaMelon

Copy link
Copy Markdown

made suggestions for incomplete sentences.
불완전한 문장 위주로 제안 드렸습니다. 확인부탁드립니다!

@BORA040126 BORA040126 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reflect sodaMelon's comment
change the order of setences, word, and incomplete senetence

@BORA040126 BORA040126 changed the title Add Korean translation for docs/ko/docs/project-generation.md 🌐Add Korean translation for docs/ko/docs/project-generation.md Sep 7, 2024
@BORA040126 BORA040126 changed the title 🌐Add Korean translation for docs/ko/docs/project-generation.md 🌐 Add Korean translation for docs/ko/docs/project-generation.md Sep 7, 2024
@github-actions

github-actions Bot commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎👍🎉

@alejsdev alejsdev changed the title 🌐 Add Korean translation for docs/ko/docs/project-generation.md 🌐 Add Korean translation for docs/ko/docs/project-generation.md Sep 7, 2024
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Sep 7, 2024
@github-actions

github-actions Bot commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 7, 2024

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev merged commit ec2a508 into fastapi:master Sep 7, 2024
@alejsdev

alejsdev commented Sep 7, 2024

Copy link
Copy Markdown
Member

Hi @BORA040126, thanks for your contribution! ✨
And thanks @sodaMelon for your review 🔍

black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants