Skip to content

📝 Update includes in docs/en/docs/advanced/security/oauth2-scopes.md#12572

Merged
alejsdev merged 4 commits into
fastapi:masterfrom
krishnamadhavan:en-docs-advanced-oauth2-scopes
Oct 29, 2024
Merged

📝 Update includes in docs/en/docs/advanced/security/oauth2-scopes.md#12572
alejsdev merged 4 commits into
fastapi:masterfrom
krishnamadhavan:en-docs-advanced-oauth2-scopes

Conversation

@krishnamadhavan

@krishnamadhavan krishnamadhavan commented Oct 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

📝 Update includes in docs/en/docs/advanced/security/oauth2-scopes.md

Part of #12554

@github-actions github-actions Bot added the docs Documentation about how to use FastAPI label Oct 26, 2024
@krishnamadhavan krishnamadhavan changed the title Update includes for docs/en/docs/advanced/security/oauth2-scopes.md Update includes for docs/en/docs/advanced/security/oauth2-scopes.md Oct 26, 2024
@github-actions

github-actions Bot commented Oct 26, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit cbaabbf at: https://d3dc419f.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev changed the title Update includes for docs/en/docs/advanced/security/oauth2-scopes.md 📝 Update includes in docs/en/docs/advanced/security/oauth2-scopes.md Oct 27, 2024
@alejsdev

alejsdev commented Oct 27, 2024

Copy link
Copy Markdown
Member

Hi @krishnamadhavan, thanks for your interest in contributing to FastAPI! I was checking the preview and it seems that there's a problem with this PR 🤔

Preview:
image

Original:
image

Also, some sections are missing, can you check what happened? Thanks in advance!

@github-actions

github-actions Bot commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 5c4f1a0 at: https://a4aae729.fastapitiangolo.pages.dev

Modified Pages

@github-actions

github-actions Bot commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 26b5384 at: https://526ddd55.fastapitiangolo.pages.dev

Modified Pages

@krishnamadhavan

krishnamadhavan commented Oct 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hi @alejsdev, Thanks for pointing it out!

The problem has been resolved now. It was due to removing the back slashes /// at the end of note blocks. I've put them back and everything looks okay to me.

Can you please review it again?

Preview:
Screenshot 2024-10-28 at 12 18 06 PM

Original:
Screenshot 2024-10-28 at 12 19 21 PM

@alejsdev alejsdev merged commit 268eac9 into fastapi:master Oct 29, 2024
@alejsdev

alejsdev commented Oct 29, 2024

Copy link
Copy Markdown
Member

It's ok now! Thanks for your help @krishnamadhavan 🚀

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@krishnamadhavan @s-rigaud
📝 Update includes in docs/en/docs/advanced/security/oauth2-scopes.md (
05a7d1f 
fastapi#12572)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docs Documentation about how to use FastAPI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krishnamadhavan @alejsdev