Skip to content

🌐 Add Korean translation for docs/ko/docs/history-design-future.md#12646

Merged
alejsdev merged 16 commits into
fastapi:masterfrom
saeye:feature/ko-docs
Nov 7, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/history-design-future.md#12646
alejsdev merged 16 commits into
fastapi:masterfrom
saeye:feature/ko-docs

Conversation

@saeye

@saeye saeye commented Oct 28, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the lang-all Translations label Oct 28, 2024
@github-actions

Copy link
Copy Markdown
Contributor

@saeye saeye changed the title Create history-design-future.md Add Korean translation for docs/ko/docs/history-design-future.md Oct 28, 2024
@alejsdev alejsdev changed the title Add Korean translation for docs/ko/docs/history-design-future.md 🌐 Add Korean translation for docs/ko/docs/history-design-future.md Oct 28, 2024
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 28, 2024
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
hi @saeye.
i left some comment to make better.

Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
Comment thread docs/ko/docs/history-design-future.md Outdated
saeye and others added 8 commits October 31, 2024 17:25
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
saeye and others added 4 commits October 31, 2024 17:26
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@saeye saeye requested a review from sodaMelon October 31, 2024 08:40
@github-actions

Copy link
Copy Markdown
Contributor

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JaeHyuckSa JaeHyuckSa left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@alejsdev alejsdev merged commit 745c073 into fastapi:master Nov 7, 2024
@alejsdev

alejsdev commented Nov 7, 2024

Copy link
Copy Markdown
Member

Thank you! @saeye 🏅
And thanks for the help @sodaMelon @JaeHyuckSa 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants