Skip to content

🌐 Add Korean translation for docs/ko/docs/advanced/templates.md#12726

Merged
alejsdev merged 8 commits into
fastapi:masterfrom
Heumhub:features/ko-advanced-templates
Dec 9, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/advanced/templates.md#12726
alejsdev merged 8 commits into
fastapi:masterfrom
Heumhub:features/ko-advanced-templates

Conversation

@Heumhub

@Heumhub Heumhub commented Oct 30, 2024

Copy link
Copy Markdown
Contributor

Add Korean translation for docs/ko/docs/advanced/templates.md

@github-actions github-actions Bot added the lang-all Translations label Oct 30, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Comment thread docs/ko/docs/advanced/templates.md
Comment thread docs/ko/docs/advanced/templates.md Outdated
Comment thread docs/ko/docs/advanced/templates.md
Comment thread docs/ko/docs/advanced/templates.md Outdated
@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 30, 2024
Heumhub and others added 2 commits November 1, 2024 18:08
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
thank you!!!

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@Heumhub Heumhub requested a review from sodaMelon November 12, 2024 07:08
Comment thread docs/ko/docs/advanced/templates.md

@sodaMelon sodaMelon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's broken. See Translation specific tips and guidelines and #3167 (comment)

In lines starting with /// translate only the text part after |. Leave the rest unchanged.

Comment thread docs/ko/docs/advanced/templates.md Outdated
Comment thread docs/ko/docs/advanced/templates.md Outdated
Comment thread docs/ko/docs/advanced/templates.md Outdated
Heumhub and others added 2 commits November 29, 2024 16:46
Co-authored-by: hy.lee <rurouni24@gmail.com>
Co-authored-by: hy.lee <rurouni24@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

Co-authored-by: hy.lee <rurouni24@gmail.com>
@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Dec 9, 2024

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev merged commit d24a334 into fastapi:master Dec 9, 2024
@alejsdev

alejsdev commented Dec 9, 2024

Copy link
Copy Markdown
Member

Thanks for your contribution! @Heumhub 🥳
And thanks for the reviews @sodaMelon, @hard-coders and @kim-sangah 🔍

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants