Skip to content

🌐 Add Korean translation for docs/ko/docs/how-to/conditional-openapi.md#12731

Merged
alejsdev merged 14 commits into
fastapi:masterfrom
sptcnl:master
Nov 7, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/how-to/conditional-openapi.md#12731
alejsdev merged 14 commits into
fastapi:masterfrom
sptcnl:master

Conversation

@sptcnl

@sptcnl sptcnl commented Oct 31, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the lang-all Translations label Oct 31, 2024
@github-actions

Copy link
Copy Markdown
Contributor

@github-actions

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 31, 2024
Comment thread docs/ko/docs/how-to/conditional-openapi.md Outdated
Comment on lines +41 to +55
그런 다음 `FastAPI` 앱을 만들 때 사용합니다.

그런 다음 환경 변수 `OPENAPI_URL`을 빈 문자열로 설정하여 OpenAPI(문서 UI 포함)를 비활성화할 수 있습니다. 예를 들어:

<div class="termy">

```console
$ OPENAPI_URL= uvicorn main:app

<span style="color: green;">INFO</span>: Uvicorn running on http://127.0.0.1:8000 (Press CTRL+C to quit)
```

</div>

그런 다음 `/openapi.json`, `/docs` 또는 `/redoc`의 URL로 이동하면 `404 Not Found`라는 오류가 다음과 같이 표시됩니다:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

원문에도 "Then", "And then" 이런 식으로 되어 있긴 하지만..
"그런 다음"이 너무 반복되어서 조금 어색합니다. 가능하다면 접속사를 조금 다듬었으면 좋겠습니다.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다!

Co-authored-by: hy.lee <rurouni24@gmail.com>
@github-actions

github-actions Bot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

@sptcnl sptcnl requested a review from hard-coders November 1, 2024 05:59

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Only one thing left to do.

Comment thread docs/ko/docs/how-to/conditional-openapi.md Outdated
Co-authored-by: hy.lee <rurouni24@gmail.com>
@github-actions

github-actions Bot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions

github-actions Bot commented Nov 3, 2024

Copy link
Copy Markdown
Contributor

@sptcnl sptcnl closed this Nov 3, 2024
@sptcnl sptcnl reopened this Nov 3, 2024
@sptcnl sptcnl closed this Nov 3, 2024
@sptcnl sptcnl reopened this Nov 3, 2024
@sptcnl sptcnl closed this Nov 4, 2024
@sptcnl sptcnl reopened this Nov 4, 2024
@sptcnl sptcnl closed this Nov 4, 2024
@sptcnl sptcnl reopened this Nov 4, 2024
@sptcnl sptcnl closed this Nov 5, 2024
@sptcnl sptcnl reopened this Nov 5, 2024
@github-actions

github-actions Bot commented Nov 5, 2024

Copy link
Copy Markdown
Contributor

@alejsdev alejsdev merged commit 2fcae5f into fastapi:master Nov 7, 2024
@alejsdev

alejsdev commented Nov 7, 2024

Copy link
Copy Markdown
Member

Cool! Thanks for the contribution @sptcnl

And thanks for the review @hard-coders 🤓

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants