Skip to content

🌐 Add Korean translation for docs/ko/docs/tutorial/query-param-models.md#12940

Merged
alejsdev merged 3 commits into
fastapi:masterfrom
timothy-jeong:master
Nov 20, 2024
Merged

🌐 Add Korean translation for docs/ko/docs/tutorial/query-param-models.md#12940
alejsdev merged 3 commits into
fastapi:masterfrom
timothy-jeong:master

Conversation

@timothy-jeong

@timothy-jeong timothy-jeong commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions github-actions Bot added the lang-all Translations label Nov 15, 2024
@github-actions

github-actions Bot commented Nov 15, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 7f36b43 at: https://b2417a30.fastapitiangolo.pages.dev

Modified Pages

@alejsdev alejsdev added lang-zh Chinese translations awaiting-review labels Nov 18, 2024
@timothy-jeong

timothy-jeong commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Hi @alejsdev ,

Thank you for reviewing my PR. I noticed that the PR is labeled with lang-zh, but it actually contains a Korean translation (lang-ko). Could you kindly update the label to lang-ko so it correctly reflects the content of the PR?

@alejsdev alejsdev added lang-ko Korean translations and removed lang-zh Chinese translations labels Nov 19, 2024
@alejsdev

alejsdev commented Nov 19, 2024

Copy link
Copy Markdown
Member

My bad! Fixed.
Thanks @jts8257 🙌

hard-coders
hard-coders suggested changes Nov 19, 2024
View reviewed changes

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! I reviewed only two points.

Comment thread docs/ko/docs/tutorial/query-param-models.md Outdated
Comment thread docs/ko/docs/tutorial/query-param-models.md Outdated
@timothy-jeong @hard-coders
Apply suggestions from code review
65f0c6d 
- 쿼리 매개변수와 모델 -> 쿼리 매개변수 모델
- FAST API -> FastAPI

Co-authored-by: hy.lee <rurouni24@gmail.com>
@github-actions

github-actions Bot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit 65f0c6d at: https://806cc883.fastapitiangolo.pages.dev

Modified Pages

@timothy-jeong

timothy-jeong commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for promptly updating the label to lang-ko, @alejsdev . I appreciate your swift action! 🙏

@timothy-jeong

timothy-jeong commented Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Thank you for your valuable feedback, @hard-coders.
I've addressed the two points you mentioned. Please let me know if there's anything else I should consider.

@github-actions

github-actions Bot commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

📝 Docs preview for commit c3a2882 at: https://bf274dac.fastapitiangolo.pages.dev

Modified Pages

hard-coders
hard-coders approved these changes Nov 20, 2024
View reviewed changes

@hard-coders hard-coders left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@alejsdev alejsdev merged commit 835b646 into fastapi:master Nov 20, 2024
@alejsdev

alejsdev commented Nov 20, 2024

Copy link
Copy Markdown
Member

Thanks for your contribution! @jts8257 🤓
And thanks for your review! @hard-coders 🚀

s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
@timothy-jeong @s-rigaud
🌐 Add Korean translation for `docs/ko/docs/tutorial/query-param-model…
f540e5c 
…s.md` (fastapi#12940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@hard-coders hard-coders hard-coders approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved-1 lang-all Translations lang-ko Korean translations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@timothy-jeong @alejsdev @hard-coders